Skip to content

Commit edf2fe7

Browse files
committed
BUG: Improve multi-channel vmin/vmax updates from the client side
1 parent b040507 commit edf2fe7

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

js/lib/viewer.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -824,27 +824,27 @@ const ViewerView = widgets.DOMWidgetView.extend({
824824
}
825825
this.model.itkVtkViewer.on('selectLookupTable', onSelectLookupTable)
826826

827-
const onChangeColorRange = (component, colorRange) => {
828-
const vmin = this.model.get('vmin')
827+
const onColorRangesChanged = (colorRanges) => {
828+
let vmin = this.model.get('vmin')
829829
if (vmin === null) {
830830
vmin = []
831831
}
832-
if (colorRange[0] !== vmin[component]) {
833-
vmin[component] = colorRange[0]
834-
this.model.set('vmin', vmin)
835-
this.model.save_changes()
836-
}
837-
const vmax = this.model.get('vmax')
832+
let vmax = this.model.get('vmax')
838833
if (vmax === null) {
839834
vmax = []
840835
}
841-
if (colorRange[1] !== vmax[component]) {
836+
const rendered_image = this.model.get('rendered_image')
837+
const components = rendered_image.imageType.components
838+
for (let component = 0; component < components; component++) {
839+
const colorRange = colorRanges[component]
840+
vmin[component] = colorRange[0]
842841
vmax[component] = colorRange[1]
843-
this.model.set('vmax', vmax)
844-
this.model.save_changes()
845842
}
843+
this.model.set('vmax', vmax)
844+
this.model.set('vmin', vmin)
845+
this.model.save_changes()
846846
}
847-
this.model.itkVtkViewer.on('changeColorRange', onChangeColorRange)
847+
this.model.itkVtkViewer.on('colorRangesChanged', onColorRangesChanged)
848848

849849
const onCroppingPlanesChanged = (planes, bboxCorners) => {
850850
if (

js/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"copy-webpack-plugin": "^5.1.1",
6464
"css-element-queries": "^1.2.3",
6565
"itk": "^13.1.1",
66-
"itk-vtk-viewer": "^10.7.2",
66+
"itk-vtk-viewer": "^10.7.3",
6767
"jupyter-dataserializers": "^2.2.0",
6868
"mobx": "^5.15.4",
6969
"regenerator-runtime": "^0.13.5",

0 commit comments

Comments
 (0)