Skip to content

Add reportQuestion enum #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Add reportQuestion enum #103

merged 2 commits into from
Dec 12, 2019

Conversation

AliAbdelfattah
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah commented Dec 12, 2019

Summary of Changes

Added enum CustomTextPlaceHolderKey.reportQuestion which maps to InstabugCustomTextPlaceHolder.Key.REPORT_QUESTION on Android and kIBGAskAQuestionStringName on iOS.

Checklist

  • In addition to adding the new API to Dart, I have also added its implementation to both iOS and Android.
  • I have added at least 1 unit test in Dart for the new API and made sure the tests pass locally.
  • I have updated README.md to add the new API.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #103 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #103      +/-   ##
=========================================
+ Coverage   76.35%   76.4%   +0.04%     
=========================================
  Files          11      11              
  Lines         478     479       +1     
=========================================
+ Hits          365     366       +1     
  Misses        113     113
Impacted Files Coverage Δ
lib/Instabug.dart 94.44% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc7a61...4f0fb6a. Read the comment docs.

@AliAbdelfattah AliAbdelfattah merged commit cafd423 into master Dec 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/report-question-string branch December 12, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants