-
Notifications
You must be signed in to change notification settings - Fork 48
[Feature] - Crash Reporting #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into crash-reporting # Conflicts: # example/android/app/build.gradle # example/ios/Runner.xcodeproj/project.pbxproj
…into crash-reporting # Conflicts: # android/build.gradle # ios/instabug_flutter.podspec
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 75.50% 73.90% -1.61%
==========================================
Files 11 14 +3
Lines 494 548 +54
==========================================
+ Hits 373 405 +32
- Misses 121 143 +22
Continue to review full report at Codecov.
|
Is this what I think it is? Crash Reporting for Flutter? Oh man. Ohhhhh man. Wooo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I noticed Java files got formatted. What formatter are you using; prettier, Android Studio, or something else?
- Gonna be reviewing dart files tomorrow.
android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java
Show resolved
Hide resolved
android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java
Show resolved
Hide resolved
…into crash-reporting # Conflicts: # .circleci/config.yml # CHANGELOG.md # README.md # android/build.gradle # android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java # example/lib/main.dart # ios/Classes/InstabugFlutterPlugin.m # ios/instabug_flutter.podspec
Summary of Changes
setCurrentPlatform
APITODO