Skip to content

[Feature] - Crash Reporting #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 13, 2020
Merged

[Feature] - Crash Reporting #127

merged 26 commits into from
Jul 13, 2020

Conversation

alyezz
Copy link
Contributor

@alyezz alyezz commented Jun 10, 2020

Summary of Changes

  • Adds Automatic Crash Reporting
  • Adds Manual Crash Reporting API
  • Adds new iOS setCurrentPlatform API
  • Updates README and Changelog

TODO

  • Revert the custom iOS branch from pod file
  • Update the Android SDK version

…into crash-reporting

# Conflicts:
#	example/android/app/build.gradle
#	example/ios/Runner.xcodeproj/project.pbxproj
…into crash-reporting

# Conflicts:
#	android/build.gradle
#	ios/instabug_flutter.podspec
@alyezz alyezz changed the title Crash reporting [Feature] - Repro Steps and Current View Jun 10, 2020
@alyezz alyezz changed the title [Feature] - Repro Steps and Current View [Feature] - Crash Reporting Jun 10, 2020
@Instabug Instabug deleted a comment from InstabugCI Jun 10, 2020
@Instabug Instabug deleted a comment from InstabugCI Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #127 into master will decrease coverage by 1.60%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   75.50%   73.90%   -1.61%     
==========================================
  Files          11       14       +3     
  Lines         494      548      +54     
==========================================
+ Hits          373      405      +32     
- Misses        121      143      +22     
Impacted Files Coverage Δ
lib/models/crash_data.dart 50.00% <50.00%> (ø)
lib/models/exception_data.dart 53.33% <53.33%> (ø)
lib/CrashReporting.dart 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c6074...2c6aaa1. Read the comment docs.

@leecommamichael
Copy link

Is this what I think it is? Crash Reporting for Flutter? Oh man. Ohhhhh man. Wooo!

@alyezz alyezz self-assigned this Jun 11, 2020
@alyezz alyezz marked this pull request as ready for review June 11, 2020 12:10
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I noticed Java files got formatted. What formatter are you using; prettier, Android Studio, or something else?
  • Gonna be reviewing dart files tomorrow.

@alyezz alyezz requested a review from AliAbdelfattah June 17, 2020 08:35
@alyezz alyezz requested a review from AliAbdelfattah June 17, 2020 15:05
alyezz added 5 commits July 13, 2020 15:16
…into crash-reporting

# Conflicts:
#	.circleci/config.yml
#	CHANGELOG.md
#	README.md
#	android/build.gradle
#	android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java
#	example/lib/main.dart
#	ios/Classes/InstabugFlutterPlugin.m
#	ios/instabug_flutter.podspec
@alyezz alyezz merged commit 03bf9aa into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the crash-reporting branch July 13, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants