Skip to content

[MOB-4686] Feature/add setDebugEnabled Android API #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahmed1hisham
Copy link
Contributor

Summary of Changes

  • Added setDebugEnabled API to enable/disable the Instabug debug logs.
  • API added for Android only
  • Unit test added to java test files only

Checklist

  • In addition to adding the new API to Dart, I have also added its implementation to both iOS and Android.
  • I have added at least 1 unit test in Dart for the new API and made sure the tests pass locally.
  • I have updated README.md to add the new API.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #174 (b4d76a2) into master (3edf75d) will decrease coverage by 0.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   69.21%   68.64%   -0.57%     
==========================================
  Files          14       14              
  Lines         484      488       +4     
==========================================
  Hits          335      335              
- Misses        149      153       +4     
Impacted Files Coverage Δ
lib/Instabug.dart 82.82% <0.00%> (-3.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edf75d...b4d76a2. Read the comment docs.

AliAbdelfattah
AliAbdelfattah previously approved these changes Apr 5, 2021
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏

@ahmed1hisham ahmed1hisham changed the title Feature/add setDebugEnabled Android API [MOB-4686] Feature/add setDebugEnabled Android API Apr 13, 2021
@AliAbdelfattah AliAbdelfattah added the READY FOR MERGE Reviewed and ready for merge (after release request) label Apr 19, 2021
@ahmed1hisham ahmed1hisham force-pushed the feature/add-set-debug-enabled-android-api branch from b4d76a2 to dc1ab10 Compare September 13, 2021 18:08
@InstabugCI
Copy link
Collaborator

1 Warning
⚠️ Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@ahmed1hisham ahmed1hisham force-pushed the feature/add-set-debug-enabled-android-api branch from dc1ab10 to 9741877 Compare September 13, 2021 18:29
@AliAbdelfattah AliAbdelfattah changed the base branch from master to feature/apm September 13, 2021 18:44
@AliAbdelfattah AliAbdelfattah merged commit 7e698d3 into feature/apm Sep 13, 2021
@AliAbdelfattah AliAbdelfattah deleted the feature/add-set-debug-enabled-android-api branch September 13, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants