-
Notifications
You must be signed in to change notification settings - Fork 50
[MOB-5589] Fix/null safety issues #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## feature/null-safety #184 +/- ##
=======================================================
- Coverage 69.21% 63.31% -5.91%
=======================================================
Files 14 14
Lines 484 447 -37
=======================================================
- Hits 335 283 -52
- Misses 149 164 +15
Continue to review full report at Codecov.
|
7abc5e6
to
fc425b4
Compare
Fixes failing tests on iOS To be investigated later
fc425b4
to
cb71e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
platformVersion
return type to nullable for consistency with flutter latest plugin templatesTODO:
Fix CI broken build scripts after updating the Flutter SDK version.