Skip to content

Conversation

AliAbdelfattah
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah commented Jul 12, 2021

Summary of Changes

  • Update platformVersion return type to nullable for consistency with flutter latest plugin templates
  • Remove (undo) result call on non-void return type values which fixes failing tests on iOS
  • Update Crash Reporting to use null-aware operators
  • Update package metadata as per the guidelines of pub.dev
  • Update package min flutter version to 1.17 instead of 2.0
  • Update package version
  • Update sample app pubspec
  • Bump Flutter SDK version used on CI from 1.20.4 to 2.2.3
  • Bump mockito version
  • Regenerate mocks
  • Fix CI broken build scripts after updating the Flutter SDK version
  • Increase network logger tests coverage

TODO:

  • Fix CI broken build scripts after updating the Flutter SDK version.
  • Increase test coverage

@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 12, 2021

1 Warning
⚠️ Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #184 (cb71e91) into feature/null-safety (3b227bf) will decrease coverage by 5.90%.
The diff coverage is 59.33%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feature/null-safety     #184      +/-   ##
=======================================================
- Coverage                69.21%   63.31%   -5.91%     
=======================================================
  Files                       14       14              
  Lines                      484      447      -37     
=======================================================
- Hits                       335      283      -52     
- Misses                     149      164      +15     
Impacted Files Coverage Δ
lib/NetworkLogger.dart 0.00% <0.00%> (ø)
lib/models/network_data.dart 0.00% <0.00%> (ø)
lib/utils/http_client_logger.dart 0.00% <0.00%> (ø)
lib/Surveys.dart 51.06% <47.05%> (ø)
lib/CrashReporting.dart 69.23% <55.55%> (+2.56%) ⬆️
lib/Replies.dart 54.83% <56.00%> (ø)
lib/BugReporting.dart 52.17% <59.25%> (-7.29%) ⬇️
lib/Chats.dart 71.42% <60.00%> (ø)
lib/FeatureRequests.dart 77.77% <71.42%> (-4.05%) ⬇️
lib/InstabugLog.dart 89.47% <75.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5c53d...cb71e91. Read the comment docs.

@AliAbdelfattah AliAbdelfattah force-pushed the fix/null-safety branch 2 times, most recently from 7abc5e6 to fc425b4 Compare July 12, 2021 14:10
@AliAbdelfattah AliAbdelfattah merged commit 0bd815c into feature/null-safety Jul 13, 2021
@AliAbdelfattah AliAbdelfattah deleted the fix/null-safety branch July 13, 2021 10:39
@AliAbdelfattah AliAbdelfattah changed the title Fix/null safety issues [MOB-5589] Fix/null safety issues Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants