Skip to content

[MOB-8741] Direct call for media projection method #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2022
Merged

[MOB-8741] Direct call for media projection method #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4117ddb
Direct call for media projection method
DavidMina96 May 17, 2022
e1956d3
Update CHANGELOG.md
DavidMina96 May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Adds BugReporting.setFloatingButtonEdge API
* Supports starting SDK from Dart only.
* Fixes an issue with Android screenshots being black on release mode on SDK v10.13.0

## v10.13.0 (2022-03-31)

Expand Down
20 changes: 5 additions & 15 deletions android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import android.util.Log;

import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;

import com.instabug.apm.APM;
import com.instabug.apm.model.ExecutionTrace;
Expand Down Expand Up @@ -165,7 +166,7 @@ public void startWithToken(String token, ArrayList<String> invocationEvents) {
.setInvocationEvents(invocationEventsArray)
.build();

enableScreenShotByMediaProjection();
enableScreenShotByMediaProjection(true);
}

/**
Expand Down Expand Up @@ -429,20 +430,9 @@ public void setValue(String value, String forStringWithKey) {
/**
* Enables taking screenshots by media projection.
*/
private void enableScreenShotByMediaProjection() {
try {
Method method = getMethod(Class.forName("com.instabug.bug.BugReporting"),
"setScreenshotByMediaProjectionEnabled", boolean.class);
if (method != null) {
method.invoke(null, true);
}
} catch (ClassNotFoundException e) {
e.printStackTrace();
} catch (IllegalAccessException e) {
e.printStackTrace();
} catch (InvocationTargetException e) {
e.printStackTrace();
}
@VisibleForTesting
public static void enableScreenShotByMediaProjection(boolean isScreenshotByMediaProjectionEnabled) {
BugReporting.setScreenshotByMediaProjectionEnabled(isScreenshotByMediaProjectionEnabled);
}

/**
Expand Down
15 changes: 3 additions & 12 deletions ...ple/android/app/src/androidTest/java/com/example/InstabugSample/InvokeInstabugUITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import static androidx.test.espresso.matcher.ViewMatchers.withResourceName;
import static androidx.test.espresso.matcher.ViewMatchers.withText;

import com.instabug.instabugflutter.InstabugFlutterPlugin;

@RunWith(AndroidJUnit4.class)
public class InvokeInstabugUITest {

Expand All @@ -37,18 +39,7 @@ public void ensureInstabugInvocati1on() throws InterruptedException {
}

private void disableScreenShotByMediaProjection() {
try {
Method method = getMethod(Class.forName("com.instabug.bug.BugReporting"), "setScreenshotByMediaProjectionEnabled", boolean.class);
if (method != null) {
method.invoke(null, false);
}
} catch (ClassNotFoundException e) {
e.printStackTrace();
} catch (IllegalAccessException e) {
e.printStackTrace();
} catch (InvocationTargetException e) {
e.printStackTrace();
}
InstabugFlutterPlugin.enableScreenShotByMediaProjection(false);
}

public static Method getMethod(Class clazz, String methodName, Class... parameterType) {
Expand Down