Skip to content

[MOB-9401] Fix Lint Issues #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 25, 2022
Merged

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Aug 18, 2022

Description of the change

  • Apply project-wide fixes for lint issues detected by package:lint
  • Fix code formatting issues

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

1 Warning
⚠️ Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #255 (c355e31) into master (48a580b) will increase coverage by 0.19%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   72.55%   72.74%   +0.19%     
==========================================
  Files          16       16              
  Lines         470      466       -4     
==========================================
- Hits          341      339       -2     
+ Misses        129      127       -2     
Impacted Files Coverage Δ
lib/src/modules/feature_requests.dart 77.77% <0.00%> (ø)
lib/src/modules/instabug_log.dart 89.47% <0.00%> (ø)
lib/src/utils/ibg_build_info.dart 30.00% <ø> (ø)
lib/src/utils/ibg_date_time.dart 50.00% <ø> (ø)
lib/src/utils/instabug_navigator_observer.dart 0.00% <0.00%> (ø)
lib/src/modules/surveys.dart 59.57% <28.57%> (ø)
lib/src/modules/bug_reporting.dart 76.71% <37.50%> (+1.03%) ⬆️
lib/src/modules/apm.dart 78.94% <40.00%> (+0.37%) ⬆️
lib/src/modules/replies.dart 67.74% <42.85%> (ø)
lib/src/models/trace.dart 41.66% <50.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DavidMina96 DavidMina96 force-pushed the refactor/fix-formatting-and-lint-issues branch from 44aaa4e to bedce44 Compare August 18, 2022 14:29
@DavidMina96 DavidMina96 changed the base branch from master to ci/add-quality-checks August 18, 2022 14:29
@DavidMina96 DavidMina96 force-pushed the ci/add-quality-checks branch from 22b8b72 to 0311ee4 Compare August 18, 2022 14:52
@DavidMina96 DavidMina96 force-pushed the refactor/fix-formatting-and-lint-issues branch 3 times, most recently from 1d81aa8 to fa4b392 Compare August 19, 2022 09:17
@DavidMina96 DavidMina96 marked this pull request as ready for review August 23, 2022 13:16
@DavidMina96 DavidMina96 self-assigned this Aug 23, 2022
@DavidMina96 DavidMina96 force-pushed the refactor/fix-formatting-and-lint-issues branch from 9362ded to 3ca2e65 Compare August 23, 2022 13:53
@DavidMina96 DavidMina96 force-pushed the ci/add-quality-checks branch 2 times, most recently from 716b12d to 86e6547 Compare August 23, 2022 14:09
@DavidMina96 DavidMina96 force-pushed the refactor/fix-formatting-and-lint-issues branch 4 times, most recently from eda2c5d to c62d4cd Compare August 23, 2022 16:08
TheBuggedYRN
TheBuggedYRN previously approved these changes Aug 24, 2022
AliAbdelfattah
AliAbdelfattah previously approved these changes Aug 25, 2022
@DavidMina96 DavidMina96 force-pushed the refactor/fix-formatting-and-lint-issues branch from c62d4cd to c355e31 Compare August 25, 2022 14:55
@DavidMina96 DavidMina96 changed the base branch from ci/add-quality-checks to master August 25, 2022 14:56
@DavidMina96 DavidMina96 dismissed stale reviews from AliAbdelfattah and TheBuggedYRN August 25, 2022 14:56

The base branch was changed.

@ymabdallah ymabdallah merged commit 05fd297 into master Aug 25, 2022
@ymabdallah ymabdallah deleted the refactor/fix-formatting-and-lint-issues branch August 25, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants