[MOB-10001] Remove Media Projection from Android #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/11.5.0 #281 +/- ##
===============================================
Coverage 81.16% 81.16%
===============================================
Files 17 17
Lines 377 377
===============================================
Hits 306 306
Misses 71 71 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TheBuggedYRN
force-pushed
the
refactor/pigeon
branch
from
c358e25 to
bd23c02
Compare
TheBuggedYRN
force-pushed
the
feat/remove-mp-android
branch
from
e6cebe6 to
66a2b2a
Compare
TheBuggedYRN
force-pushed
the
feat/remove-mp-android
branch
from
66a2b2a to
bf44ef1
Compare
DavidMina96
approved these changes
Nov 24, 2022
TheBuggedYRN
added a commit
that referenced
this pull request
Nov 24, 2022
TheBuggedYRN
added a commit
that referenced
this pull request
Nov 24, 2022
When invoking Instabug on Android, a "scary" dialog appears, asking for permission to record screen. This was due to the way we captured screenshots on Android, using Media Projection, since other alternatives didn't work with Flutter. This PR aims at providing an alternative approach for Media Projection, using FlutterRenderer to capture screenshots. This implicitly fixes Repro Steps on Android as well.
HeshamMegid
pushed a commit
that referenced
this pull request
Nov 24, 2022
When invoking Instabug on Android, a "scary" dialog appears, asking for permission to record screen. This was due to the way we captured screenshots on Android, using Media Projection, since other alternatives didn't work with Flutter. This PR aims at providing an alternative approach for Media Projection, using FlutterRenderer to capture screenshots. This implicitly fixes Repro Steps on Android as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When invoking Instabug on Android, a "scary" dialog appears, asking for permission to record screen. This was due to the way we captured screenshots on Android, using Media Projection, since other alternatives didn't work with Flutter.
This PR aims at providing an alternative approach for Media Projection, using
FlutterRendererto capture screenshots. This implicitly fixes Repro Steps on Android as well.Type of change
Related issues
Checklists
Development
Code review