Skip to content

[MOB-10896] Remove Redundant Native Logs #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Dec 1, 2022

Description of the change

Some APIs forcefully logged some info, even without debug mode enabled. These APIs include:

  1. Starting the SDK
  2. Crash Reporting APIs on Android
  3. All Network logs on iOS
  4. Repro Steps screenshots on Android

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Dec 1, 2022
@TheBuggedYRN TheBuggedYRN force-pushed the fix/remove-native-logs branch from c832ada to 0bbc04f Compare December 1, 2022 10:43
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #303 (661717f) into dev (e685b65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #303   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          17       17           
  Lines         382      382           
=======================================
  Hits          310      310           
  Misses         72       72           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TheBuggedYRN TheBuggedYRN force-pushed the fix/remove-native-logs branch 2 times, most recently from c8defa3 to 4a81293 Compare December 1, 2022 12:57
@TheBuggedYRN TheBuggedYRN force-pushed the fix/remove-native-logs branch from 4a81293 to 661717f Compare December 1, 2022 12:57
@TheBuggedYRN TheBuggedYRN merged commit f3099ad into dev Dec 1, 2022
@TheBuggedYRN TheBuggedYRN deleted the fix/remove-native-logs branch December 1, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants