Skip to content

[MOB-10573] Support setSdkDebugLogsLevel on Android #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 22, 2022

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Dec 1, 2022

Description of the change

We had two different native APIs for SDK logs, which were mapped accordingly in Flutter. Since this is now unified natively, this PR does the following:

  1. Adds setSdkDebugLogsLevel implementation on Android.
  2. Deprecates setDebugEnabled and updates its implementation to use the new API when called on Android, in addition to the related unit tests.
  3. Removes setDebugEnabled from the native bridge.

Note:
This is based on an internal snapshot, so the Android tests are expected to fail until we bump to the Android release, including this API.

To-Do:

Rebase the PR after bumping the Android version ✅

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #304 (fa5bff2) into dev (c7f8142) will decrease coverage by 0.18%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              dev     #304      +/-   ##
==========================================
- Coverage   83.92%   83.73%   -0.19%     
==========================================
  Files          17       17              
  Lines         367      369       +2     
==========================================
+ Hits          308      309       +1     
- Misses         59       60       +1     
Impacted Files Coverage Δ
lib/src/modules/instabug.dart 96.51% <75.00%> (-1.11%) ⬇️
lib/src/modules/apm.dart 96.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DavidMina96 DavidMina96 self-assigned this Dec 1, 2022
@DavidMina96 DavidMina96 changed the title [MOB-10573] Support setSdkDebugLogsLevel on Android [MOB-10573] Support setSdkDebugLogsLevel on Android Dec 1, 2022
@DavidMina96 DavidMina96 added the pending-android Waiting for Android release label Dec 7, 2022
@DavidMina96 DavidMina96 force-pushed the feature/add-new-debug-logs-api branch from fa5bff2 to d94ccde Compare December 22, 2022 09:04
@DavidMina96 DavidMina96 merged commit 170b8d2 into dev Dec 22, 2022
@DavidMina96 DavidMina96 deleted the feature/add-new-debug-logs-api branch December 22, 2022 09:49
@DavidMina96 DavidMina96 removed the pending-android Waiting for Android release label Dec 22, 2022
HeshamMegid pushed a commit that referenced this pull request Dec 29, 2022
* Add setSdkDebugLogsLevel implementation on Android

* Deprecate setDebugEnabled API

* Remove setDebugEnabled from Android bridge

* Deprecate APM.setLogLevel

* Update CHANGELOG.md

* Remove setDebugEnabled from pigeon spec and iOS

* Add `setSdkDebugLogsLevel` Android test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants