-
Notifications
You must be signed in to change notification settings - Fork 47
[MOB-10573] Support setSdkDebugLogsLevel
on Android
#304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #304 +/- ##
==========================================
- Coverage 83.92% 83.73% -0.19%
==========================================
Files 17 17
Lines 367 369 +2
==========================================
+ Hits 308 309 +1
- Misses 59 60 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
setSdkDebugLogsLevel
on Android
TheBuggedYRN
suggested changes
Dec 1, 2022
TheBuggedYRN
approved these changes
Dec 1, 2022
fa5bff2
to
d94ccde
Compare
7 tasks
HeshamMegid
pushed a commit
that referenced
this pull request
Dec 29, 2022
* Add setSdkDebugLogsLevel implementation on Android * Deprecate setDebugEnabled API * Remove setDebugEnabled from Android bridge * Deprecate APM.setLogLevel * Update CHANGELOG.md * Remove setDebugEnabled from pigeon spec and iOS * Add `setSdkDebugLogsLevel` Android test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
We had two different native APIs for SDK logs, which were mapped accordingly in Flutter. Since this is now unified natively, this PR does the following:
setSdkDebugLogsLevel
implementation on Android.setDebugEnabled
and updates its implementation to use the new API when called on Android, in addition to the related unit tests.Note:
This is based on an internal snapshot, so the Android tests are expected to fail until we bump to the Android release, including this API.
To-Do:
Rebase the PR after bumping the Android version ✅
Type of change
Related issues
Checklists
Development
Code review