Skip to content

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Dec 1, 2022

Description of the change

Add these string keys: okButtonText, audio, image, screenRecording, messagesNotificationAndOthers, insufficientContentTitle, insufficientContentMessage with their mapping on both platforms (if relevant).

Note:
This is based on an internal snapshot, so the Android tests are expected to fail until we bump to the Android release including the new keys.

To-Do:
Rebase the PR after bumping the Android version ✅

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 self-assigned this Dec 1, 2022
@DavidMina96 DavidMina96 changed the base branch from master to dev December 1, 2022 17:07
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #305 (47c0b70) into dev (c7f8142) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #305   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files          17       17           
  Lines         367      367           
=======================================
  Hits          308      308           
  Misses         59       59           
Impacted Files Coverage Δ
lib/src/modules/instabug.dart 97.61% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DavidMina96 DavidMina96 force-pushed the feature/add-more-string-keys branch from 47c0b70 to bc61385 Compare December 7, 2022 13:55
@TheBuggedYRN TheBuggedYRN added the pending-android Waiting for Android release label Dec 7, 2022
@DavidMina96 DavidMina96 force-pushed the feature/add-more-string-keys branch from bc61385 to ce8994c Compare December 22, 2022 08:33
@DavidMina96 DavidMina96 removed the pending-android Waiting for Android release label Dec 22, 2022
@DavidMina96 DavidMina96 merged commit 07c0d19 into dev Dec 22, 2022
@DavidMina96 DavidMina96 deleted the feature/add-more-string-keys branch December 22, 2022 08:44
HeshamMegid pushed a commit that referenced this pull request Dec 29, 2022
* Add more string keys

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants