Skip to content

[MOB-12122] Migrate Danger to TypeScript #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2023
Merged

[MOB-12122] Migrate Danger to TypeScript #351

merged 2 commits into from
Apr 10, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Apr 9, 2023

Description of the change

Migrates the current Dangerfile to TypeScript as an intermediate step for the upcoming code coverage plugin.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev requested a review from DavidMina96 April 9, 2023 20:05
@a7medev a7medev self-assigned this Apr 9, 2023
@a7medev a7medev merged commit 84418c5 into dev Apr 10, 2023
@a7medev a7medev deleted the ci/danger-to-ts branch April 10, 2023 10:33
HeshamMegid pushed a commit that referenced this pull request Apr 12, 2023
@a7medev @HeshamMegid
[MOB-12122] Migrate Danger to TypeScript (#351)
0faf11e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a7medev @DavidMina96