[MOB 2943] Flutter API: setValueForStringWithKey #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeshamMegid
approved these changes
Mar 17, 2019
There was a problem hiding this comment.
@salmamali do we also need to update the pubspec file for the package name change?
| */ | ||
| public void setValue(String value, String forStringWithKey) { | ||
| InstabugCustomTextPlaceHolder.Key key = ArgsRegistry.getDeserializedValue(forStringWithKey, InstabugCustomTextPlaceHolder.Key.class); | ||
| placeHolder.set(key, value); |
There was a problem hiding this comment.
Nice hack 👏 I like it 😄
Muhammadyoussef
suggested changes
Mar 17, 2019
android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java
Outdated
Show resolved
Hide resolved
salmamali
commented
Mar 17, 2019
There was a problem hiding this comment.
@salmamali do we also need to update the pubspec file for the package name change?
@HeshamMegid
The module name change will not affect the name of the package itself. And changing the name of the package now will create a completely new package on pub than the one published now. Should we still make this change?
Muhammadyoussef
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added APIs and Enums
Instabug.setValueForStringWithKey(String value, String key)The enum:
IBGCustomTextPlaceHolderKeyAdded unit test for the added API
Added Android unit test for the added enum.
Updated Readme
Changed flutter module name from
InstabugFluttertoInstabugRemoved some lint warnings