[Mob 3185]: Flutter API: sessionProfilerEnabled #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alyezz
commented
Mar 31, 2019
alyezz
commented
- Android API Mapping
- IOS API Mapping
- Flutter API Mapping
- Adds tests for new API
- updates Readme
- updated Changelog
HeshamMegid
reviewed
Mar 31, 2019
| * @param sessionProfilerEnabled desired state of the session profiler feature | ||
| */ | ||
| public void setSessionProfilerEnabled(boolean sessionProfilerEnabled) { | ||
| try { |
There was a problem hiding this comment.
Do we need a try/catch here? Would that be caught by the calling method?
HeshamMegid
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.