Skip to content

Fix exception in navigation observer with Flutter 3.35.3 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix exception in navigation observer with Flutter 3.35.3 #639

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f1088c
Update instabug_navigator_observer.dart
BDR-Thermea-B2B-apps Sep 12, 2025
3ff836b
Add comment
BDR-Thermea-B2B-apps Sep 12, 2025
888e930
Update instabug_navigator_observer.dart
BDR-Thermea-B2B-apps Sep 12, 2025
42cf311
Update instabug_navigator_observer.dart
BDR-Thermea-B2B-apps Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/instabug_flutter/lib/src/utils/instabug_navigator_observer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,22 @@ class InstabugNavigatorObserver extends NavigatorObserver {
// If there is a step that hasn't been pushed yet
if (_steps.isNotEmpty) {
await reportScreenChange(_steps.last.name);
}
// Check again if there is a step that hasn't been pushed yet after the async operation above.
if (_steps.isNotEmpty) {
// Report the last step and remove it from the list
_steps.removeLast();
}

// Add the new step to the list
_steps.add(route);

// If this route is in the array, report it and remove it from the list
// If this route is in the array, report it
if (_steps.contains(route)) {
await reportScreenChange(route.name);
}
// Check again if this route is still in the list after async operation, remove it from the list
if (_steps.contains(route)) {
_steps.remove(route);
}
});
Expand Down