Skip to content

Feature/network logging #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 22, 2019
Merged

Feature/network logging #82

merged 10 commits into from
Jul 22, 2019

Conversation

salmamali
Copy link
Contributor

Summary of Changes

  • Network logging for the dart:io network package httpClient.
  • Creates a custom class tha implements HttpClient.
  • Add tests.

@salmamali salmamali requested a review from HeshamMegid July 11, 2019 09:54
@salmamali salmamali self-assigned this Jul 11, 2019
@@ -34,6 +34,6 @@ android {
}

dependencies {
implementation 'com.instabug.library:instabug:8.4.0.0'
implementation 'com.instabug.library:instabug:8.4.0.1'
Copy link
Contributor

@alyezz alyezz Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will release after merging, we should update the latest version 8.5.0.1

@alyezz
Copy link
Contributor

alyezz commented Jul 11, 2019

I think we should update the Readme.

  • Add Network logging as a feature
  • How to use it (HttpClient)
  • links to the other libraries

Copy link
Contributor

@HeshamMegid HeshamMegid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the readme update @alyezz suggested.

@salmamali salmamali requested review from HeshamMegid and alyezz July 18, 2019 10:55
@salmamali salmamali merged commit e95907d into master Jul 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/networkLogging branch July 22, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants