Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): get application through react context #1069

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Nov 26, 2023

Description of the change

Get the Android Application instance when initializing the SDK through the reactContext instead of getCurrentActivity since it can be null sometimes causing the SDK to crash.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: [INSD-10472] [Dream11] Feature flag crashing IBG library

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 95.8%
Android 50.3%
iOS 40.6%

Generated by 🚫 dangerJS against 3287076

@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from master to dev November 26, 2023 11:41
@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/12.2.0-INSD-10472

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/12.2.0-INSD-10472

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort ✅ !!

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 2ef72a7 into dev Nov 26, 2023
11 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the fix/android-app-from-context branch November 26, 2023 17:50
@abdelhamid-f-nasser abdelhamid-f-nasser mentioned this pull request Nov 26, 2023
7 tasks
HeshamMegid pushed a commit that referenced this pull request Dec 7, 2023
Jira ID: [\[INSD-10472\] \[Dream11\] Feature flag crashing IBG library ](https://instabug.atlassian.net/browse/INSD-10472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants