Feature/new release apis #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote parameter as per the native SDK
…he native api and removing the voice note attribute
index.js
Outdated
| * @param {boolean} screenRecording A boolean to enable or disable screen recording attachments. | ||
| */ | ||
| setAttachmentTypesEnabled: function (screenshot, extraScreenshot, galleryImage, voiceNote, screenRecording) { | ||
| Instabug.setAttachmentTypesEnabled(screenshot, extraScreenshot, galleryImage, voiceNote, screenRecording); |
There was a problem hiding this comment.
@salmatarzi Salma This change will break users code because they are currently using it with 5 params
Instead: You may need to create a new API and keep the old one and mark it as deprecated,
Don't forget to modify the old API to navigate to the new one.
… to the new native api
yousefhamza
approved these changes
Jan 6, 2018
| @@ -382,7 +406,21 @@ module.exports = { | |||
| * @param {boolean} screenRecording A boolean to enable or disable screen recording attachments. | |||
| */ | |||
| setAttachmentTypesEnabled: function (screenshot, extraScreenshot, galleryImage, voiceNote, screenRecording) { | |||
| Instabug.setAttachmentTypesEnabled(screenshot, extraScreenshot, galleryImage, voiceNote, screenRecording); | |||
| Instabug.setEnabledAttachmentTypes(screenshot, extraScreenshot, galleryImage, screenRecording); | |||
There was a problem hiding this comment.
Double check they r the same order in both of the native SDKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.