Skip to content

podspec #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

podspec #31

wants to merge 1 commit into from

Conversation

djhr
Copy link

@djhr djhr commented May 1, 2017

No description provided.

@yousefhamza
Copy link
Contributor

Those file will be linked to the react native iOS project when you run:
react-native link instabug-reactnative

@yousefhamza yousefhamza closed this Jun 1, 2017
@djhr
Copy link
Author

djhr commented Jun 4, 2017

react-native link instabug-reactnative will link the module to the ios/android project, not generate the podspec file. For people linking the modules via cocoapods (instead of react-native link) this podspec file is needed. Have a look at other modules and you will see that most of them provide a podspec file, even react native itself provide a podspec (https://github.com/facebook/react-native/blob/master/React.podspec) to link it via cocoapods

@djhr
Copy link
Author

djhr commented Jun 19, 2017

@yousefhamza any update on this?

@djhr
Copy link
Author

djhr commented Jul 12, 2017

@DevHossamHassan can you have a look at this PR, I think @yousefhamza didn't understand the value/purpose of it so it was closed. Linking modules via cocoapods is very common, and I think would be great this module to support it too.

@yousefhamza
Copy link
Contributor

Hey @djhr sorry, I didn't get back to you earlier.

I really do appreciate your persistence because taking a second look at it, Our current linking to Instabug is very hacky and this is a much better solution. I want to test a couple of cases first then I will get back to you by today 👍

@yousefhamza yousefhamza reopened this Jul 12, 2017
@yousefhamza
Copy link
Contributor

@djhr I'm afraid it doesn't work for us.

The React Pod you refer to is now deprecated and it's version doesn't satisfy our minimum requirement for React, also adding it in a pod cause name conflicts between React in Pods directory and React in node_modules directory

ticolucci pushed a commit to ticolucci/instabug-reactnative that referenced this pull request Jul 20, 2017
@djhr
Copy link
Author

djhr commented Aug 22, 2017

@yousefhamza sorry for the delay getting back to you.

The React Pod you refer to is now deprecated and it's version doesn't satisfy our minimum requirement for React

On the podspec file you can specify which version of the dependency you want, e.g.
s.dependency 'Instabug', '~> 7.0' or
s.dependency 'Instabug ~> 7.0' not sure which one it is, but one of the two works

adding it in a pod cause name conflicts between React in Pods directory and React in node_modules directory

My guess is you mixed react-native link with podspec. When you opt for podspec as your installation method you need to do it for everything, including react native lib itself, e.g.

platform :ios, '8.0'

target 'Sample' do
  use_frameworks!

  # Pods for Sample
  pod 'React', :path => '../node_modules/react-native', :subspecs => [
    'Core',
    'DevSupport',
    'RCTActionSheet',
    'RCTAnimation',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTPushNotification',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket'
  ]
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
  pod 'instabug-reactnative', :path => '../node_modules/instabug-reactnative'

  target 'SampleTests' do
    inherit! :search_paths
    pod 'React', :path => '../node_modules/react-native', :subspecs => [
      'Core',
      'DevSupport',
      'RCTActionSheet',
      'RCTAnimation',
      'RCTGeolocation',
      'RCTImage',
      'RCTLinkingIOS',
      'RCTPushNotification',
      'RCTNetwork',
      'RCTSettings',
      'RCTText',
      'RCTVibration',
      'RCTWebSocket'
    ]
  end

end

Also important, after you do pod init you should start using the .xcworkspace file to open the project on xcode instead of .xcodeproj file

Some helpful resources:
http://facebook.github.io/react-native/releases/0.47/docs/integration-with-existing-apps.html#configuring-cocoapods-dependencies

As last note, I have it working on a project, so it has to be a matter of configuration/steps

@mzsoliman mzsoliman requested a review from salmatarzi August 22, 2017 17:35
@salmatarzi
Copy link
Contributor

@djhr

On the podspec file you can specify which version of the dependency you want, e.g.
s.dependency 'Instabug', '~> 7.0' or
s.dependency 'Instabug ~> 7.0' not sure which one it is, but one of the two works

The latest React pod version released is below our latest minimum requirement for React as dependency

My guess is you mixed react-native link with podspec. When you opt for podspec as your installation method you need to do it for everything, including react native lib itself, e.g.

In the podspec file, you cannot specify the path as shown in your example, this could be done in the Podfile itself.

@djhr djhr closed this Oct 11, 2017
@oblador oblador mentioned this pull request Nov 16, 2017
salmamali added a commit that referenced this pull request Dec 9, 2018
ahmed1hisham pushed a commit that referenced this pull request Sep 13, 2021
* 📝 change invoking method to handle return values

* ✨ add android and ios maps for getTags

* ✨ add dart API for getTags

* ✨ add getTags to the example app

* ✨ add getTags test

* Update README.md

* 📚 Add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants