Salmat/test release #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevHossamHassan
suggested changes
Jul 24, 2017
package.json
Outdated
| @@ -23,7 +23,7 @@ | |||
| "homepage": "https://github.com/Instabug/instabug-reactnative#readme", | |||
| "rnpm": { | |||
| "android": { | |||
| "packageInstance": "new RNInstabugReactnativePackage(\"YOUR_ANDROID_APPLICATION_TOKEN\",MainApplication.this,\"shake\",\"#1D82DC\")" | |||
| "packageInstance": "new RNInstabugReactnativePackage.Builder(\"YOUR_ANDROID_APPLICATION_TOKEN\",MainApplication.this)\n.setInvocationEvent(\"shake\")\n.build()" | |||
There was a problem hiding this comment.
@salmatarzi I'd prefer to add all other options here with their default values.
| @@ -26,7 +27,8 @@ | |||
| private InstabugColorTheme instabugColorTheme = InstabugColorTheme.InstabugColorThemeLight; | |||
|
|
|||
| public RNInstabugReactnativePackage(String androidApplicationToken, Application androidApplication, | |||
| String invocationEventValue, String primaryColor) { | |||
| String invocationEventValue, String primaryColor, | |||
| InstabugFloatingButtonEdge floatingButtonEdge, int offset) { | |||
There was a problem hiding this comment.
@salmatarzi This will break users' apps, we should deprecate the old constructor and change its implementation to make use of this constructor and not to duplicate the code.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "instabug-reactnative", | |||
| "version": "1.1.6", | |||
| "version": "1.1.8", | |||
There was a problem hiding this comment.
Please keep the version number as it was, Since we are going to pump it later on.
DevHossamHassan
approved these changes
Jul 24, 2017
…constructor to be left
salmamali
pushed a commit
that referenced
this pull request
Mar 27, 2019
ahmed1hisham
pushed a commit
that referenced
this pull request
Sep 13, 2021
* 📝 Updates Changelog * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.