[MOB-4605] Typescript Definition Validation #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alyezz
commented
Oct 7, 2020
alyezz
commented
- Adds a script that compares the Javascript files with the typescript definition file and reports all discrepancies.
- Adds this script as a step in CI
AliAbdelfattah
previously approved these changes
Nov 7, 2020
|
Requires rebasing on master. |
…ative into feature/typescript-validation
* Fix discrepancies reported by the type validator * Fix comments on the typescript validator * Fix jest testing error * Fix param name in crash reporting module
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 24 24
Lines 424 424
Branches 82 82
=======================================
Hits 365 365
Misses 49 49
Partials 10 10
Continue to review full report at Codecov.
|
AliAbdelfattah
approved these changes
Mar 24, 2021
AliAbdelfattah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.