Skip to content

Updated PR template #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2020
Merged

Updated PR template #527

merged 3 commits into from
Oct 13, 2020

Conversation

bsameh-at-instabug
Copy link
Contributor

@bsameh-at-instabug bsameh-at-instabug commented Oct 12, 2020 •
edited
Loading

Description of the change

Updated the default PR template to enforce our checklist.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@anwarelwakil anwarelwakil merged commit ad0cfc9 into master Oct 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the pr-template branch October 13, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@anwarelwakil anwarelwakil anwarelwakil approved these changes

@alyezz alyezz alyezz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsameh-at-instabug @anwarelwakil @alyezz