Fix/fix callback invocations #54
Conversation
package.json
Outdated
| @@ -23,7 +23,7 @@ | |||
| "homepage": "https://github.com/Instabug/instabug-reactnative#readme", | |||
| "rnpm": { | |||
| "android": { | |||
| "packageInstance": "new RNInstabugReactnativePackage.Builder(\"YOUR_ANDROID_APPLICATION_TOKEN\",MainApplication.this)\n.setInvocationEvent(\"shake\")\n.setPrimaryColor(\"#1D82DC\")\n.setFloatingEdge(\"left\")\n.setFloatingButtonOffsetFromTop(250)\n.build()" | |||
| "packageInstance": "new RNInstabugReactnativePackage.Builder(\"YOUR_ANDROID_APPLICATION_TOKEN\",MainApplication.this)\n .setInvocationEvent(\"shake\")\n .setPrimaryColor(\"#1D82DC\")\n .setFloatingEdge(\"left\")\n .setFloatingButtonOffsetFromTop(250)\n .build()" | |||
There was a problem hiding this comment.
@salmatarzi Please use tabs instead of spaces
There was a problem hiding this comment.
@salmatarzi Also please don't exceed standard line length which is 80 characters per line.
There was a problem hiding this comment.
and please reformat this file to meet the Java standards
| postInvocationHandler.invoke(); | ||
| WritableMap params = Arguments.createMap(); | ||
| params.putString("issueState",issueState.toString()); | ||
| params.putString("bugType",bugType.toString()); |
There was a problem hiding this comment.
@salmatarzi Please adjust the indentation here.
| try { | ||
| String[] result = tags.split(","); | ||
| String[] result = new String[tags.size()]; | ||
| for(int i = 0; i < tags.size(); i++) { |
There was a problem hiding this comment.
@salmatarzi Please there is missed space after for and the open brace
There was a problem hiding this comment.
@salmatarzi Instead of converting this yourself you can use ArrayUtil.toArray(ReadableArray readableArray);
There was a problem hiding this comment.
@DevHossamHassan Yes, I was looking for something like that!
| @@ -212,9 +212,12 @@ public void dismiss() { | |||
| * @param tags | |||
| */ | |||
| @ReactMethod | |||
| public void appendTags(String tags) { | |||
| public void appendTags(ReadableArray tags) { | |||
Exposes environment variable to be set in android and ios for the APP TOKEN Renames the token inside the script to INSTABUG_APP_TOKEN
Android API Mapping IOS API Mapping Flutter API Mapping Adds tests for new API updates Readme updated Changelog Changed setPrimaryColor and setSessionProfilerEnabled to use NSNumber instead of NSString
No description provided.