Skip to content

[MOB-5142] Replace iOS dynamic framework with XCFramework #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 21, 2021

Conversation

AliAbdelfattah
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah commented Apr 18, 2021

Description of the change

  • Removed ios/Instabug.framework.
  • Added ios/Instabug.xcframework.
  • Updated framework references.
  • Updated CI scripts.

Type of change

  • New feature (non-breaking change that adds functionality)

Checklists

Development

  • Lint rules pass locally

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b4eb79f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #573   +/-   ##
=========================================
  Coverage          ?   86.08%           
=========================================
  Files             ?       24           
  Lines             ?      424           
  Branches          ?       82           
=========================================
  Hits              ?      365           
  Misses            ?       49           
  Partials          ?       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eb79f...923ba3f. Read the comment docs.

@AliAbdelfattah AliAbdelfattah added the READY FOR MERGE Reviewed and ready for merge (after release request) label Apr 19, 2021
@AliAbdelfattah AliAbdelfattah changed the base branch from master to rel/10.3.0 April 21, 2021 14:21
@AliAbdelfattah AliAbdelfattah merged commit 67e86ab into rel/10.3.0 Apr 21, 2021
@AliAbdelfattah AliAbdelfattah deleted the fix/xcframework branch April 21, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants