Skip to content

[IBGCRASH-9968] Split CR exception message parameter #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

ahmed1hisham
Copy link
Contributor

Description of the change

In a Crash Report, the exception JSON object has a parameter message that was a combination between name and message of the exception. This PR splits this parameter into e_name and e_message .

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmed1hisham ahmed1hisham changed the title Split CR exception message parameter [IBGCRASH-9968] Split CR exception message parameter Feb 8, 2022
@ahmed1hisham ahmed1hisham force-pushed the Fix/split-exception-parameter branch 3 times, most recently from 735ff94 to bdd1141 Compare February 8, 2022 10:57
@ahmed1hisham ahmed1hisham force-pushed the Fix/split-exception-parameter branch from bdd1141 to 324447c Compare February 8, 2022 10:59
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #668 (ca09968) into master (dd6075a) will not change coverage.
The diff coverage is n/a.

❗ Current head ca09968 differs from pull request most recent head 324447c. Consider uploading reports for the commit 324447c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          24       24           
  Lines         459      459           
  Branches       91       91           
=======================================
  Hits          405      405           
  Misses         46       46           
  Partials        8        8           
Impacted Files Coverage Δ
modules/CrashReporting.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6075a...324447c. Read the comment docs.

@AliAbdelfattah AliAbdelfattah added the READY FOR MERGE Reviewed and ready for merge (after release request) label Mar 9, 2022
@AliAbdelfattah AliAbdelfattah changed the base branch from master to release/10.13.0 March 9, 2022 12:33
@AliAbdelfattah AliAbdelfattah merged commit d741c91 into release/10.13.0 Mar 9, 2022
@AliAbdelfattah AliAbdelfattah deleted the Fix/split-exception-parameter branch March 9, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants