Skip to content

[MOB-8359] Add Expirements APIs #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 9, 2022
Merged

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Feb 28, 2022

Description of the change

Added support for:

  • Instabug.addExperiments
  • Instabug.removeExperiments
  • Instabug.clearAllExperiments

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Feb 28, 2022
@AliAbdelfattah AliAbdelfattah changed the title [MOB-8359] Add Expirements APIs (under Instabug module) [MOB-8359] Add Expirements APIs Mar 1, 2022
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 💪
One minor comment.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #671 (0f75552) into master (6b4ea10) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   88.23%   88.31%   +0.07%     
==========================================
  Files          24       24              
  Lines         459      462       +3     
  Branches       91       91              
==========================================
+ Hits          405      408       +3     
  Misses         46       46              
  Partials        8        8              
Impacted Files Coverage Δ
jest/mockInstabug.js 100.00% <ø> (ø)
index.js 78.62% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4ea10...0f75552. Read the comment docs.

@AliAbdelfattah AliAbdelfattah added the READY FOR MERGE Reviewed and ready for merge (after release request) label Mar 9, 2022
@AliAbdelfattah AliAbdelfattah changed the base branch from master to release/10.13.0 March 9, 2022 12:20
@AliAbdelfattah AliAbdelfattah merged commit 7de4651 into release/10.13.0 Mar 9, 2022
@AliAbdelfattah AliAbdelfattah deleted the feature/experiments branch March 9, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants