Implementing constants bridge for andriod #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactoring use of strings in internal functions to use constatns - Expose string constants through `getConstants` react method.
|
I opened another PR against dev branch instead. Closing this one. |
ahmed1hisham
added a commit
that referenced
this pull request
Sep 13, 2021
* Feature/apm support flutter (#6) * Add setEnabled API for APM * Add setColdAppLaunchEnabled API for APM * Add setAutoUITraceEnabled API for APM * Add support for APM Execution Traces metric * Add APIs that start and end UI trace * Add specs for APIs that start and end UI trace * Fix APM.setEnabled * Add setLogLevel API for APM * Fix iOS setLogLevel missing variable * Fix execution traces APIs * Update network logging to support APM for iOS * Fix network requests always getting logged as a failure * Fix APM null safety * Fix network logger responseHeaders population * Fix network data model * Add ignore static member warning * Add network logging for Android * Remove unwanted logs * Fix execution traces specs * Fix network log payload size for iOS * Fix InstabugCustomHttpClient request closing * Call setCurrentPlatform instead of setCrossPlatform * Adjust APM Network logger for other network libs * Add debugging log for apmNetworkLog * Undo comments in InstabugFlutterPlugin.java * Fix duration in Android bug reporting network logs * Remove commented code * Undo SDK versions Co-authored-by: Ahmed Hisham Rihan <36399893+ahmed1hisham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConstantsreact method.@DevHossamHassan trying to address this issue #6