Skip to content

[MOB-6504] Fix android ci oom #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022
Merged

[MOB-6504] Fix android ci oom #742

merged 2 commits into from
Jul 27, 2022

Conversation

AliAbdelfattah
Copy link
Contributor

Description of the change

  • Increase java max heap size.
  • Clean up ci config from the unused context

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #742 (90fcc36) into master (74b4cbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          22       22           
  Lines         599      599           
  Branches       93       93           
=======================================
  Hits          538      538           
  Misses         53       53           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@@ -26,3 +26,6 @@ android.enableJetifier=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.99.0

# Max heap size
org.gradle.jvmargs=-Xmx4608m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass it from CI environment instead?

@ymabdallah ymabdallah merged commit 4a06cb0 into master Jul 27, 2022
@ymabdallah ymabdallah deleted the chore/android-ci-oom branch July 27, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants