Skip to content

[MOB-9109] Bump deprecated Xcode versions for affected CI jobs #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Jul 26, 2022

Description of the change

  • Bumps xcode version to v13.4.1 for test_ios, e2e_ios and publish jobs
  • Bumps Detox version to v19.8.4

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 self-assigned this Jul 26, 2022
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The publish job would also need to be bumped.
  • Please rebase the branch on master to resolve the android_ci job failure.

@DavidMina96 DavidMina96 force-pushed the ci/bump-deprecated-xcode-versions branch 2 times, most recently from 04e4cd7 to 55f5634 Compare July 28, 2022 11:21
@DavidMina96 DavidMina96 force-pushed the ci/bump-deprecated-xcode-versions branch from 55f5634 to 47671ab Compare July 28, 2022 12:26
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #743 (0856ea0) into master (4a06cb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          22       22           
  Lines         599      599           
  Branches       93       93           
=======================================
  Hits          538      538           
  Misses         53       53           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@DavidMina96 DavidMina96 changed the title [MOB-9109] Bump deprecated Xcode versions for iOS CI jobs [MOB-9109] Bump deprecated Xcode versions for affected CI jobs Jul 28, 2022
@ymabdallah ymabdallah merged commit 445aee9 into master Jul 28, 2022
@ymabdallah ymabdallah deleted the ci/bump-deprecated-xcode-versions branch July 28, 2022 16:18
@TheBuggedYRN TheBuggedYRN mentioned this pull request Aug 24, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants