Skip to content

[MOB-9315] Adjust Hermes path for RN 0.69 onwards #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Aug 29, 2022

Description of the change

Adjusts Hermes path in Android source maps auto upload script to support Bundled Hermes on RN 0.69 onwards

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #750 (1b2fa98) into master (17b4dce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          22       22           
  Lines         599      599           
  Branches       93       93           
=======================================
  Hits          538      538           
  Misses         53       53           
  Partials        8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DavidMina96 DavidMina96 self-assigned this Aug 29, 2022
@DavidMina96 DavidMina96 marked this pull request as ready for review August 29, 2022 10:16
TheBuggedYRN
TheBuggedYRN previously approved these changes Aug 29, 2022
a7medev
a7medev previously approved these changes Aug 29, 2022
AliAbdelfattah
AliAbdelfattah previously approved these changes Aug 30, 2022
Co-authored-by: Ali Abdelfattah <aabdelfattah@instabug.com>
@ymabdallah ymabdallah merged commit 0871f7b into master Aug 30, 2022
@ymabdallah ymabdallah deleted the fix/android-sourcemaps-with-bundled-hermes branch August 30, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants