Skip to content

[MOB-9436] Hermes Support for iOS Source Maps Auto Upload #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2022

Conversation

DavidMina96
Copy link
Contributor

Description of the change

  • Augment ios upload_sourcemap.sh script with the necessary changes to support Hermes

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

TheBuggedYRN
TheBuggedYRN previously approved these changes Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #756 (9265ec5) into master (3f74afe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          22       22           
  Lines         599      599           
  Branches       93       93           
=======================================
  Hits          538      538           
  Misses         53       53           
  Partials        8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AliAbdelfattah
AliAbdelfattah previously approved these changes Sep 12, 2022
TheBuggedYRN
TheBuggedYRN previously approved these changes Sep 15, 2022
TheBuggedYRN
TheBuggedYRN previously approved these changes Sep 15, 2022
@DavidMina96 DavidMina96 force-pushed the feature/hermes-ios-sourcemaps-auto-upload branch from 81d6ea7 to 9265ec5 Compare September 15, 2022 15:09
@ymabdallah ymabdallah merged commit d560f3a into master Sep 18, 2022
@ymabdallah ymabdallah deleted the feature/hermes-ios-sourcemaps-auto-upload branch September 18, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants