Skip to content

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Apr 3, 2025

Really exciting project! I thought you might find a crate I wrote useful for this project. This crate should make it easier to generate the byte code by automatically handling the constant pool offsets for long/double, as well translate logical instruction pointers to byte code offsets, etc.

@brianheineman brianheineman force-pushed the update-to-use-ristretto-classfile branch from 685b1c6 to 9703d0d Compare April 4, 2025 00:32
@IntegralPilot
Copy link
Owner

Thank you so much for making your amazing crate and for helping me integrate it, this code is much cleaner now! All tests pass locally, so I'm going to merge this. Thanks again! :)

@IntegralPilot IntegralPilot merged commit 384e03b into IntegralPilot:main Apr 4, 2025
@brianheineman brianheineman deleted the update-to-use-ristretto-classfile branch April 4, 2025 02:43
@brianheineman
Copy link
Contributor Author

brianheineman commented Apr 4, 2025

@IntegralPilot I'm glad you find it helpful! I realized that I should be providing a means to calculate the max_stack and max_locals as well. I put together a PR to address calculating the max_stack size; I'll try to get that released soon and submit another PR that will hopefully simplify a bit more for you: theseus-rs/ristretto#295, theseus-rs/ristretto#296, theseus-rs/ristretto#300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants