Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Composer #154

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Better Composer #154

wants to merge 4 commits into from

Conversation

dxoigmn
Copy link
Contributor

@dxoigmn dxoigmn commented Jun 5, 2023

What does this PR do?

  • Make Composer an nn.Module.
  • Think more carefully about Composers vis-a-vis universal composers versus sample-specific composers.
  • Make Composers actually composable instead of inheriting from each other. A good first start is turn Composer into an nn.Module.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn changed the title Better Compose Better Composer Jun 5, 2023
@dxoigmn dxoigmn mentioned this pull request Jun 5, 2023
20 tasks
@dxoigmn
Copy link
Contributor Author

dxoigmn commented Jun 8, 2023

@mzweilin: i could use your help on thinking about how to compose composers. the problem i'm seeing is that some composer want to modify the input and others want to modify the perturbation. right now, composers only returned a new input so there's no way to propagate changes to the perturbation.

some changes to perturbation are independent of the input, but others are not (e.g., resizing the perturbation to the size of the input). it's worth keeping in mind the use case in #132.

@dxoigmn
Copy link
Contributor Author

dxoigmn commented Jun 8, 2023

We can also just not worry about composition of composers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant