Use direct dpctl.tensor creation functions in tests instead of copying from host #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduced run-time of test_usm_ndarray_ctor by 3 seconds (from 16.5 to 13.5 on my machine) and marginally improves coverage of Python source file.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1166/index.html |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_96 ran successfully. |
ndgrigorian
approved these changes
Apr 10, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_96 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced pattern
dpt.from_numpy(np.creation_op(...))withdpt.creation_op(...)where applicable.This change decreased test-suite runtime by 3 seconds.