impl_ele_funcs_floor_ceil_trunc #1243

vtavana · 2023-06-14T00:19:14Z

In this PR, the following elementwise functions are implemented: dptctl.tensor.floor, dpctl.tensor.ceil, and dpctl.tensor.trunc.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-06-14T00:53:53Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1243/index.html

coveralls · 2023-06-14T00:57:49Z

coverage: 83.219% (+0.02%) from 83.195% when pulling a2c0aee on elementwise-floor-ceil-trunc into f52182d on master.

github-actions · 2023-06-14T01:04:25Z

Array API standard conformance tests for dpctl=0.14.3=py310h7bf5fec_2 ran successfully.
Passed: 412
Failed: 588
Skipped: 119

github-actions · 2023-06-14T01:19:00Z

Array API standard conformance tests for dpctl=0.14.3=py310h7bf5fec_2 ran successfully.
Passed: 410
Failed: 590
Skipped: 119

github-actions · 2023-06-14T01:21:08Z

Array API standard conformance tests for dpctl=0.14.3=py310h7bf5fec_2 ran successfully.
Passed: 412
Failed: 588
Skipped: 119

dpctl/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp

github-actions · 2023-06-16T16:06:21Z

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_6 ran successfully.
Passed: 413
Failed: 587
Skipped: 119

github-actions · 2023-06-16T17:35:08Z

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_9 ran successfully.
Passed: 415
Failed: 585
Skipped: 119

github-actions · 2023-06-17T01:13:18Z

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_10 ran successfully.
Passed: 414
Failed: 586
Skipped: 119

github-actions · 2023-06-19T02:05:40Z

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_10 ran successfully.
Passed: 415
Failed: 585
Skipped: 119

github-actions · 2023-07-04T06:46:53Z

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_12 ran successfully.
Passed: 427
Failed: 573
Skipped: 119

oleksandr-pavlyk · 2023-07-12T19:25:57Z

The output type for of integer type inputs should be the appropriate floating point type.

Python 3.9.12 (main, Jun  1 2022, 11:38:51)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.4.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import numpy as np

In [2]: np.floor.types
Out[2]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [3]: np.ceil.types
Out[3]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [4]: np.trunc.types
Out[4]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [5]: import dpctl.tensor as dpt

In [6]: import dpctl.tensor._tensor_impl as ti

In [7]: ti._ceil_result_type(dpt.int64)
Out[7]: dtype('int64')

In [8]: dpt.ceil(dpt.ones(10, dtype="uint32"))
Out[8]: usm_ndarray([1, 1, 1, 1, 1, 1, 1, 1, 1, 1], dtype=uint32)

In [9]: np.ceil(np.ones(10, dtype="uint32"))
Out[9]: array([1., 1., 1., 1., 1., 1., 1., 1., 1., 1.])

…eil-trunc

vtavana · 2023-07-17T10:26:04Z

The output type for of integer type inputs should be the appropriate floating point type.

Python 3.9.12 (main, Jun  1 2022, 11:38:51)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.4.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import numpy as np

In [2]: np.floor.types
Out[2]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [3]: np.ceil.types
Out[3]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [4]: np.trunc.types
Out[4]: ['e->e', 'f->f', 'd->d', 'f->f', 'd->d', 'g->g', 'O->O']

In [5]: import dpctl.tensor as dpt

In [6]: import dpctl.tensor._tensor_impl as ti

In [7]: ti._ceil_result_type(dpt.int64)
Out[7]: dtype('int64')

In [8]: dpt.ceil(dpt.ones(10, dtype="uint32"))
Out[8]: usm_ndarray([1, 1, 1, 1, 1, 1, 1, 1, 1, 1], dtype=uint32)

In [9]: np.ceil(np.ones(10, dtype="uint32"))
Out[9]: array([1., 1., 1., 1., 1., 1., 1., 1., 1., 1.])

Yes, the behavior is different than numpy since Array API for ceil, floor and trunc says that "the returned array must have the same data type as input."

oleksandr-pavlyk · 2023-07-17T10:30:08Z

Yes, I asked for clarification: data-apis/array-api#657

github-actions · 2023-07-17T11:33:32Z

Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_15 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

oleksandr-pavlyk · 2023-07-17T11:44:47Z

Why are these tests so slow?

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ python -m pytest --durations=6 dpctl/tests/elementwise/test_floor_ceil_trunc.py
============================================================================ test session starts ============================================================================
platform linux -- Python 3.9.12, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/opavlyk/repos/dpctl
plugins: metadata-2.0.4, json-report-1.5.0, cov-4.0.0, hypothesis-6.75.3, scikit-learn-1.3.dev0
collected 186 items

dpctl/tests/elementwise/test_floor_ceil_trunc.py ..............................sss.......................................sss.................................sss..... [ 62%]
.........................sss..............................sss......sss                                                                                                [100%]

============================================================================ slowest 6 durations ============================================================================
7.31s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[host-trunc-UnaryElementwiseFunc]
6.96s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[shared-ceil-UnaryElementwiseFunc]
6.49s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[host-floor-UnaryElementwiseFunc]
6.46s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[shared-trunc-UnaryElementwiseFunc]
6.34s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[host-ceil-UnaryElementwiseFunc]
5.97s call     dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_usm_type[shared-floor-UnaryElementwiseFunc]
================================================================ 168 passed, 18 skipped in 103.48s (0:01:43) ================================================================

I am going to push changes to these tests to make them run faster.

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ python -m pytest --durations=6 dpctl/tests/elementwise/test_floor_ceil_trunc.py ============================================================================ test session starts ============================================================================ platform linux -- Python 3.9.12, pytest-7.1.2, pluggy-1.0.0 rootdir: /home/opavlyk/repos/dpctl plugins: metadata-2.0.4, json-report-1.5.0, cov-4.0.0, hypothesis-6.75.3, scikit-learn-1.3.dev0 collected 186 items dpctl/tests/elementwise/test_floor_ceil_trunc.py ..............................sss.......................................sss.................................sss..... [ 62%] .........................sss..............................sss......sss [100%] ============================================================================ slowest 6 durations ============================================================================ 0.35s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_out_type[i1-UnaryElementwiseFunc0] 0.15s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_order[u8-trunc-UnaryElementwiseFunc] 0.14s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_order[u4-ceil-UnaryElementwiseFunc] 0.14s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_order[f2-floor-UnaryElementwiseFunc] 0.14s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_order[f4-trunc-UnaryElementwiseFunc] 0.14s call dpctl/tests/elementwise/test_floor_ceil_trunc.py::test_floor_ceil_trunc_order[u1-floor-UnaryElementwiseFunc] ====================================================================== 168 passed, 18 skipped in 9.74s ======================================================================

github-actions · 2023-07-17T12:41:15Z

Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_16 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

…eil-trunc

github-actions · 2023-07-17T20:29:31Z

Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_26 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

…eil-trunc

github-actions · 2023-07-18T13:35:26Z

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_9 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

github-actions · 2023-07-18T21:34:57Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2023-07-18T22:25:47Z

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_15 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

vtavana self-assigned this Jun 14, 2023

vtavana force-pushed the elementwise-floor-ceil-trunc branch 2 times, most recently from ea0debd to 53643f3 Compare June 14, 2023 00:31

vtavana marked this pull request as ready for review June 14, 2023 13:29

vtavana requested review from ndgrigorian and vlad-perevezentsev June 14, 2023 13:30

ndgrigorian reviewed Jun 16, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp Outdated Show resolved Hide resolved

ndgrigorian reviewed Jun 16, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp Outdated Show resolved Hide resolved

vtavana force-pushed the elementwise-floor-ceil-trunc branch from 1663477 to 0e31948 Compare June 16, 2023 16:31

vtavana force-pushed the elementwise-floor-ceil-trunc branch from a23ebdd to 9b3b889 Compare June 19, 2023 01:16

Vahid Tavanashad and others added 4 commits July 3, 2023 22:23

impl_ele_funcs_floor_ceil_trunc

d1c88a6

address reviewer's comments

be63aaf

modification to handle a special case

60b87c0

floor and ceil unnecessary calls to std::signbit removed

ea451ff

ndgrigorian force-pushed the elementwise-floor-ceil-trunc branch from 9b3b889 to ea451ff Compare July 4, 2023 05:40

Merge remote-tracking branch 'origin/master' into elementwise-floor-c…

72231d0

…eil-trunc

Merge remote-tracking branch 'origin/master' into elementwise-floor-c…

c4f972b

…eil-trunc

oleksandr-pavlyk self-requested a review July 17, 2023 21:45

Merge remote-tracking branch 'origin/master' into elementwise-floor-c…

a2c0aee

…eil-trunc

oleksandr-pavlyk merged commit 8a019d1 into master Jul 18, 2023

oleksandr-pavlyk deleted the elementwise-floor-ceil-trunc branch July 18, 2023 21:34

impl_ele_funcs_floor_ceil_trunc #1243

impl_ele_funcs_floor_ceil_trunc #1243

Uh oh!

Conversation

vtavana commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2023

Uh oh!

coveralls commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2023

Uh oh!

github-actions bot commented Jun 14, 2023

Uh oh!

github-actions bot commented Jun 14, 2023

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 16, 2023

Uh oh!

github-actions bot commented Jun 17, 2023

Uh oh!

github-actions bot commented Jun 19, 2023

Uh oh!

github-actions bot commented Jul 4, 2023

Uh oh!

oleksandr-pavlyk commented Jul 12, 2023

Uh oh!

vtavana commented Jul 17, 2023

Uh oh!

oleksandr-pavlyk commented Jul 17, 2023

Uh oh!

github-actions bot commented Jul 17, 2023

Uh oh!

oleksandr-pavlyk commented Jul 17, 2023

Uh oh!

github-actions bot commented Jul 17, 2023

Uh oh!

github-actions bot commented Jul 17, 2023

Uh oh!

github-actions bot commented Jul 18, 2023

Uh oh!

github-actions bot commented Jul 18, 2023

Uh oh!

github-actions bot commented Jul 18, 2023

Uh oh!

Uh oh!

vtavana commented Jun 14, 2023 •

edited

Loading

coveralls commented Jun 14, 2023 •

edited

Loading