Skip to content

Remove python_extension_module #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ZzEeKkAa
Copy link
Contributor

python_extension_module raises errors when building with cmake>=3.27. To workaround it, use new way to include python into CMake and use python_add_library instead of add_library.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the fix/remove_python_extension_module branch 3 times, most recently from b8f5391 to 291ddfd Compare September 11, 2023 21:50
@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2023

Coverage Status

coverage: 85.774%. remained the same when pulling 2d8f32c on ZzEeKkAa:fix/remove_python_extension_module into b1c19fe on IntelPython:master.

ZzEeKkAa and others added 2 commits September 22, 2023 13:27
We should not stop users from trying to build dpctl with older
version of Python and older version of NumPy.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix/remove_python_extension_module branch from 291ddfd to 2d8f32c Compare September 23, 2023 13:13
@oleksandr-pavlyk
Copy link
Contributor

I rebased the branch, and added a commit to remove specifying minimum required version of Python (as we should not prevent users from building with older Python and supported NumPy). Good to go in. Thank you for contributing @ZzEeKkAa !

@oleksandr-pavlyk oleksandr-pavlyk merged commit 33ece78 into IntelPython:master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants