-
Notifications
You must be signed in to change notification settings - Fork 31
Service improvements #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service improvements #1508
Conversation
…ueries `python -m dpctl --includes` will no longer load SYCL runtime libraries. Module file acquired three more options --include-dir --tensor-include-dir --library-dir This would output absolute path to directory of include headers, tensor include hedaers, and directory containing DPCTLSyclInterface library. `FindDpctl.cmake` has been renamed to `dpctl-config.cmake`. This allows downstream objects to hint CMake to finding Dpctl package by using standard mechanism: `-DDpctl_ROOT=$(python -m dpctl --cmakedir)`
Update comments in dpctl-config.cmake
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1508/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_34 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_35 ran successfully. |
|
I've checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested building extensions with these changes, and using -DDpctl_ROOT=$(python -m dpctl --cmakedir)
It works for me out of the box, so LGTM
|
It turns out To accomplish running queries like |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
dpctl/__main__.pyno longer triggers loading of libsycl library for queriespython -m dpctl --includeswill no longer load SYCL runtime libraries.Module file acquired three more options
This would output absolute path to directory of include headers,
tensor include headers, and directory containing DPCTLSyclInterface
library.
FindDpctl.cmakehas been renamed todpctl-config.cmake.This PR also installs
dpctl-config.cmaketo${PREFIX}/lib/cmakefolder, makingfind_package(Dpctl)work out of the box withdpctlinstalled in the Python environment.With local build of
dpctl, downstream projects can hint CMake to finding Dpctl package byusing standard mechanism: