Skip to content

Review of beginners_guides section #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdmoore1
Copy link
Contributor

@bdmoore1 bdmoore1 commented May 4, 2024

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Minor changes to fix grammar and clarity in the beginners guides section of the documentation.

@bdmoore1
Copy link
Contributor Author

bdmoore1 commented May 4, 2024

@ndgrigorian please add you and @xaleryb as reviewers.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing the text @bdmoore1

I left a nit question, but the changes make the text read better

@coveralls
Copy link
Collaborator

coveralls commented May 4, 2024

Coverage Status

coverage: 87.892%. remained the same
when pulling 454a089 on bdmoore1:bdmoore1-beginner-guides-review05032024
into 0df3bec on IntelPython:master.

Changing back to systemwide based on Oleksandr's findings.
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM too!

@oleksandr-pavlyk oleksandr-pavlyk merged commit e18c2fd into IntelPython:master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants