Skip to content

Add project root folder to include_dirs in _cython_api setup script #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Add project root folder to include_dirs in _cython_api setup script #2147

merged 1 commit into from
Sep 16, 2025

Conversation

sycloid
Copy link
Contributor

@sycloid sycloid commented Sep 13, 2025

Add project root folder to include_dirs in the "setup_cython_api.py" so that Cython can find dpctl/__init__.pxd

This resolves gh-2146 for me locally with Cython 3.1.3

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@intel-python-devops
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.269% (-0.6%) from 85.908%
when pulling bc34f84 on sycloid:fix-test-cython-api
into 52ab452 on IntelPython:master.

@ndgrigorian
Copy link
Collaborator

@sycloid
thank you for the contribution, in general the change seems fine to me

please set up pre-commit (per our contributing guide) and use it to make this commit match our Python style

@sycloid
Add project root folder to include_dirs in _cython_api setup script
b03ce57 
Add project root folder to include_dirs in the setup_cython_api.py
so that Cython can find dpctl/__init__.pxd

This resolves IntelPythongh-2146 for me locally with Cython 3.1.3
@sycloid sycloid force-pushed the fix-test-cython-api branch from bc34f84 to b03ce57 Compare September 15, 2025 13:23
ndgrigorian
ndgrigorian approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again @sycloid

@ndgrigorian ndgrigorian merged commit 8219167 into IntelPython:master Sep 16, 2025
34 of 35 checks passed
@sycloid sycloid deleted the fix-test-cython-api branch September 16, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR running test_sycl_queue.py::test_cython_api on editable install
4 participants
@sycloid @intel-python-devops @coveralls @ndgrigorian