Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 16, 2025

This PR proposes using if %ERRORLEVEL% neq 0 exit 1 in bld.bat wheel copying, which is more general than if errorlevel 1 exit 1

A similar change was suggested when adding the recipe to conda-forge

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Sep 16, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_129 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2025

Coverage Status

coverage: 85.208%. remained the same
when pulling 3d7f165 on generalize-bld-bat-error-check
into e13069b on master.

@ndgrigorian ndgrigorian changed the title Make error check in bld.bat wheel copy more general Make error checks in .bat files more general Sep 17, 2025
@ndgrigorian ndgrigorian changed the title Make error checks in .bat files more general [MAINT] Make error checks in .bat files more general Sep 17, 2025
@ndgrigorian ndgrigorian force-pushed the generalize-bld-bat-error-check branch from 23ea096 to 3d7f165 Compare September 17, 2025 17:25
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_132 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, LGTM

@ndgrigorian ndgrigorian merged commit 3091e5b into master Sep 17, 2025
34 of 35 checks passed
@ndgrigorian ndgrigorian deleted the generalize-bld-bat-error-check branch September 17, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants