Skip to content

Conversation

sycloid
Copy link
Contributor

@sycloid sycloid commented Sep 27, 2025

This resolves gh-2159.

After this change 3 license-related warnings disappear.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@sycloid
Copy link
Contributor Author

sycloid commented Sep 27, 2025

With this change:

$ python scripts/build_locally.py --compiler-root=${HOME}/sycl-builds/test_llvm/build_sycl --c-compiler=${HOME}/sycl-builds/test_llvm/build_sycl/bin/clang --cxx-compiler=${HOME}/sycl-builds/test_llvm/build_sycl/bin/clang++
/home/sycloid/miniforge/envs/dev_dpctl/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:90: DevelopDeprecationWarning: develop command is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` and ``develop``.
        Instead, use standards-based tools like pip or uv.

        By 2025-Oct-31, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.

        See https://github.com/pypa/setuptools/issues/917 for details.
        ********************************************************************************

!!
  self.initialize_options()
[0/1] Re-running CMake...
-- dpcpp ver[0]: clang version 21.0.0git (https://github.com/intel/llvm 611e24571eab5d0bebeea859200484e68ba910ff)
-- dpcpp ver[1]: Target: x86_64-unknown-linux-gnu
<snipped>

@intel-python-devops
Copy link

Can one of the admins verify this patch?

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.262%. remained the same
when pulling 28996ed on sycloid:resolve-license-deprecation-warnings
into 878cc19 on IntelPython:master.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sycloid

@ndgrigorian ndgrigorian merged commit 58d5ce9 into IntelPython:master Sep 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setuptools license deprecation warnings spewn during build
5 participants