Implementing USM memory management #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the class to use.
…erfaces.
- Separates out the queue manager from the sycl queue interface wrapper.
- Added API to get context, device froma Sycl queue.
- Added C-API wrappers for sycl device, queue, context interfaces exposing
some of the API functionalities. More can be added as needed.
- The dppl extension now defines extension types for sycl quque, device, context to
mimic the C API.
- Sycl queues are now returned to callers as a SyclQueue extension type rather than
a Py_capsule.
New line at EOF.
PokhodenkoSA
commented
Sep 18, 2020
dppl/_memory.pyx
Outdated
Comment on lines
24
to
29
| if (ptr_type == "shared"): | ||
| p = DPPLmalloc_shared(nbytes, q.get_queue_ref()) | ||
| elif (ptr_type == "host"): | ||
| p = DPPLmalloc_host(nbytes, q.get_queue_ref()) | ||
| elif (ptr_type == "device"): | ||
| p = DPPLmalloc_device(nbytes, q.get_queue_ref()) |
There was a problem hiding this comment.
Need better solution. Polymorphism?
| @@ -0,0 +1,106 @@ | |||
| ##===------------- backend.pyx - DPPL interface ------*- Cython -*-------===## | |||
There was a problem hiding this comment.
New name for the file needed.
| } | ||
|
|
||
| extensions = [ | ||
| Extension('dppl._sycl_core', [os.path.abspath('dppl/sycl_core.pyx'),], |
There was a problem hiding this comment.
Rename sycl_core.pyx to _sycl_core.pyx. #38
diptorupd
suggested changes
Sep 18, 2020
Closed
|
@diptorupd I have fixed all critical remarks. Could you please review it? |
|
Looks good. Thanks :). Let's merege |
diptorupd
approved these changes
Sep 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
Cython module created.
Need refactoring for matching new requirements.
Contains changes from #30.