Skip to content

Standardizes the names of DPPL functions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Sep 22, 2020
Merged

Standardizes the names of DPPL functions #44

merged 46 commits into from
Sep 22, 2020

Conversation

diptorupd
Copy link
Contributor

Closes #41

PokhodenkoSA and others added 30 commits September 15, 2020 10:33
@PokhodenkoSA
Move _memory.pyx
defc264
@PokhodenkoSA
Import setuptools before Cython. Otherwise, both might disagree about…
8b811c5 
… the class to use.
@PokhodenkoSA
Add dppl._memory Cython module.
0704258
@PokhodenkoSA
Run dppl/tests/dppl_tests too when run all unit tests.
e57927d
@PokhodenkoSA
Add tests for memory manager.
267492f
@PokhodenkoSA
Split tests for memory. One test one context (no, CPU, GPU).
5ff3eb0
@PokhodenkoSA
[opt] Rename getpyexts() to extensions().
902bc8a
@diptorupd
Adds C and Cython API for portions of Sycl queue, device, context int…
5d81879 
…erfaces.

     - Separates out the queue manager from the sycl queue interface wrapper.
     - Added API to get context, device froma  Sycl queue.
     - Added C-API wrappers for sycl device, queue, context interfaces exposing
       some of the API functionalities. More can be added as needed.
     - The dppl extension now defines extension types for sycl quque, device, context to
       mimic the C API.
     - Sycl queues are now returned to callers as a SyclQueue extension type rather than
       a Py_capsule.
@PokhodenkoSA
Add C-API stub library for sycl memory.
758aacc
@diptorupd
Add missing DPPL_API.
35a4674
@diptorupd
Move platform specific functions into a separate file.
7bb5faf
@diptorupd
Create a single utility function to delete C strings.
4a11490
@PokhodenkoSA
Update backends/source/dppl_utils.cpp
6e246fb 
New line at EOF.
@PokhodenkoSA
Merge branch 'pr/30' into feature/usm
97b53ca
@PokhodenkoSA
Add _sycl_core.pxd file.
abcf6f3
@PokhodenkoSA
Remove using of PyCapsule in _memory.pyx.
039b794
@PokhodenkoSA
Small style fixes in _memory.pyx.
dc72b03
@PokhodenkoSA
Moved functions from _memory.pyx to C-API interface library.
b5ab5d6
@PokhodenkoSA
Move Cython definitions for backend to single pxd file.
c57c05c
@PokhodenkoSA
Remove SyclQueue from _memory.pyx
c075f0c
@PokhodenkoSA
Use SyclQueue from
708fd1f
@PokhodenkoSA
Remove cl::sycl::queue from _memory.pyx
5d3db20
@PokhodenkoSA
Removed commented code from _memory.pyx
6747080
@PokhodenkoSA
Eliminate temporary context object.
56241ef
@PokhodenkoSA
Fix style.
7fabbe4
@PokhodenkoSA
Add MemoryUSM* classes.
abd373b
@PokhodenkoSA
Add __getbuffer__ to Shared and Host MemoryUSM classes.
ba3e497
@PokhodenkoSA
Rename C-API types for USM.
00d63b0
@PokhodenkoSA
Add DPPLUSM_GetPointerType and remove types from CL/sycl.hpp from _me…
28f0496 
…mory.pyx
@PokhodenkoSA
Clean unused code from _memory_.pyx
80cec2a
@PokhodenkoSA
Copy link
Contributor

Checked locally (with merge master) - works fine.

PokhodenkoSA
PokhodenkoSA approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PokhodenkoSA PokhodenkoSA merged commit d98be7b into IntelPython:master Sep 22, 2020
@diptorupd diptorupd deleted the rename_functions branch September 22, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Follow standard naming convention for all DPPL_XXXX function.

2 participants

@diptorupd @PokhodenkoSA