Skip to content

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR

  • adds the DPCTLEvent_GetCommandExecutionStatus function, which returns the value of the DPCTLSyclEventStatusType enumeration for the DPCTLSyclEventRef argument.
  • adds a new DPCTLSyclEventStatusType enumeration for all types from the SYCL specification
  • adds DPCTL_SyclEventStatusToDPCTLEventStatusType converter function from sycl:: info to DPCTLSyclEventStatusType enumeration types

@coveralls
Copy link
Collaborator

coveralls commented Jul 29, 2021

Coverage Status

Coverage increased (+0.0002%) to 64.829% when pulling 9aff276 on vlad-perevezentsev:event_getinfo into 3475ed4 on IntelPython:master.

@@ -196,3 +196,16 @@ DPCTLPartitionAffinityDomainType DPCTL_SyclPartitionAffinityDomainToDPCTLType(
*/
DPCTL_API
int64_t DPCTL_GetRelativeDeviceId(const sycl::device &Device);

/*!
* @brief Converts a sycl::info::event_command_status enum value to
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @brief Converts a sycl::info::event_command_status enum value to
* @brief Converts a ``sycl::info::event_command_status`` enum value to

* @brief Converts a sycl::info::event_command_status enum value to
* corresponding DPCTLSyclEventStatusType enum value.
*
* @param SyclESTy sycl::info::event_command_status to be converted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param SyclESTy sycl::info::event_command_status to be converted
* @param SyclESTy ``sycl::info::event_command_status`` to be converted

* @param SyclESTy sycl::info::event_command_status to be converted
* to DPCTLSyclEventStatusType enum.
* @return A DPCTLSyclEventStatusType enum value for the input
* sycl::info::event_command_status enum value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* sycl::info::event_command_status enum value.
* ``sycl::info::event_command_status`` enum value.

* @brief Returns the DPCTLSyclEventStatusType enum value for the
* DPCTLSyclEventRef argument.
*
* @param ERef Opaque pointer to a sycl::event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param ERef Opaque pointer to a sycl::event
* @param ERef Opaque pointer to a ``sycl::event``

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlad-perevezentsev vlad-perevezentsev added 4 - Ready to merge Review and testing done, is ready to merge and removed 2 - Ready for Review labels Aug 3, 2021
@vlad-perevezentsev vlad-perevezentsev merged commit b283185 into IntelPython:master Aug 4, 2021
@vlad-perevezentsev vlad-perevezentsev deleted the event_getinfo branch August 5, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants