Skip to content

Fix leftover PyDPPL use and add/update copyright notices. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2020
Merged

Fix leftover PyDPPL use and add/update copyright notices. #57

merged 2 commits into from
Sep 23, 2020

Conversation

diptorupd
Copy link
Contributor

No description provided.

PokhodenkoSA
PokhodenkoSA reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that dpCtl is better than Dpctl. I would prefer to name the product dpCtl because it is easier to read. But in Pyhton world modules and packages should be named dpctl because it should be case sensitive.

dpctl/__init__.py Outdated
Data Parallel Control (dpctl)
PyDPPL provides a lightweight Python abstraction over DPC++/SYCL and
Dpctl provides a lightweight Python abstraction over DPC++/SYCL and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dpctl provides a lightweight Python abstraction over DPC++/SYCL and
dpCtl provides a lightweight Python abstraction over DPC++/SYCL and

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The module is dpctl and the project dpCtl

@diptorupd diptorupd merged commit 8db38c0 into IntelPython:master Sep 23, 2020
@diptorupd diptorupd deleted the fix/leftover_name_changes branch September 23, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diptorupd @PokhodenkoSA