Skip to content

replace host_device device type with host in test #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

replace host_device device type with host in test #616

merged 1 commit into from
Oct 4, 2021

Conversation

oleksandr-pavlyk
Copy link
Contributor

Per filter selector spec, correct way to refer to host backend and host device is "host:host", so make tests do so.

The filter string "host:host_device" was tripping OS llvm/sycl compiler.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.4%) to 73.796% when pulling a372db1 on host_device_to_host into 10db385 on master.

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Oct 3, 2021
Merged
@oleksandr-pavlyk oleksandr-pavlyk merged commit 1b713d2 into master Oct 4, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the host_device_to_host branch October 4, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd