Skip to content

[FIX] versioneer 0.21 regression fixed in vendored file #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2022
Merged

[FIX] versioneer 0.21 regression fixed in vendored file #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
537437d
versioneer 0.20 regression fixed
oleksandr-pavlyk Feb 28, 2022
78f6369
test_service::test__version__ checks for untagged
oleksandr-pavlyk Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dpctl/tests/test_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def test___version__():
dpctl_ver = getattr(dpctl, "__version__", None)
assert type(dpctl_ver) is str
assert "unknown" not in dpctl_ver
assert "untagged" not in dpctl_ver
# Reg expr from PEP-440, relaxed to allow for semantic variant
# 0.9.0dev0 allowed, vs. PEP-440 compliant 0.9.0.dev0
reg_expr = (
Expand Down
2 changes: 1 addition & 1 deletion versioneer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, runner=run_command):
TAG_PREFIX_REGEX = "*"
if sys.platform == "win32":
GITS = ["git.cmd", "git.exe"]
TAG_PREFIX_REGEX = r"\*"
TAG_PREFIX_REGEX = r"*" # r"\*" - using escape on windows breaks tag extraction

_, rc = runner(GITS, ["rev-parse", "--git-dir"], cwd=root,
hide_stderr=True)
Expand Down