Raises dedicate exception type of failure to create SyclDevice #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be ValueError, now SyclDeviceCreationError is raised. removed incorrect comment Adjusted example sycl_queue to handle error creating sub-devices lower the value of partition keyword from 4 to 2
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/826/index.html |
Used it in SyclContext constructor. Modified tests.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed error type raised on failure to create
SyclDevice.It used to be
ValueError, nowSyclDeviceCreationErroris raised.Also this error and
SyclSubDeviceCreationErrorare now exported todpctlnamespace.Remove incorrect comment in
sycl_queue.py.Adjusted example
sycl_queueto handle error creating sub-devices.Lowered the value of partition keyword from 4 to 2