Add default context #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

oleksandr-pavlyk merged 9 commits into master from add-default-context

May 2, 2022

Contributor

oleksandr-pavlyk commented May 2, 2022

Adds DPCTLPlatform_GetDefaultContext that exposes sycl::platform::ext_oneapi_get_default_context() (ext_oneapi_default_context extension).


          Removed unused variable per compiler warning

0168cec

github-actions bot commented May 2, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/827/index.html

Collaborator

coveralls commented May 2, 2022 •

edited

Loading

Coverage decreased (-0.01%) to 82.856% when pulling 534fb61 on add-default-context into 7a86fbf on master.

oleksandr-pavlyk force-pushed the add-default-context branch from 08764a7 to bf369c9 Compare

May 2, 2022 11:59


          Added DPCTLPlatform_GetDefaultContext and tests

626b210

oleksandr-pavlyk force-pushed the add-default-context branch from bf369c9 to 626b210 Compare

May 2, 2022 12:29

oleksandr-pavlyk added 4 commits

May 2, 2022 07:30


          exported DPCTLPlatform_GetDefaultContext

0bb4f4b


          Added SyclPlatform.default_context property

d0e6bf5


          added SyclDevice.platform property

9cacc0e


          Added tests for SyclPlatform.default_context and SyclDevice.platform

8c24539

Contributor Author

oleksandr-pavlyk commented May 2, 2022

@diptorupd Do you think SyclDevice.platform should be SyclDevice.sycl_platform instead?

oleksandr-pavlyk requested a review from diptorupd

May 2, 2022 13:07

oleksandr-pavlyk mentioned this pull request

Add a stub for queues to the user manual. #741

Merged

diptorupd reviewed

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

dpctl/_sycl_device.pyx Show resolved Hide resolved


          fixed indent in definition of platform property

febbca4

diptorupd reviewed

View reviewed changes

dpctl/tests/test_sycl_platform.py Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

libsyclinterface/source/dpctl_sycl_platform_interface.cpp Outdated Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

libsyclinterface/tests/test_sycl_queue_interface.cpp Show resolved Hide resolved

diptorupd reviewed

View reviewed changes

dpctl/tests/test_sycl_device.py Show resolved Hide resolved

oleksandr-pavlyk added 2 commits

May 2, 2022 14:42


          Correct error message reported for null argument to DPCTLDevice_GetPl…

…atform


          Renamed SyclDevice.platform property to SyclDevice.sycl_platform for …

534fb61

…consistency

diptorupd approved these changes

View reviewed changes

oleksandr-pavlyk merged commit f16d6d1 into master

oleksandr-pavlyk deleted the add-default-context branch

May 2, 2022 21:10

github-actions bot commented May 2, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

oleksandr-pavlyk mentioned this pull request

dpctl.SyclPlatform should provide get_devices method #509

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet