Excised use of DPCTL_COVERAGE preprocessor variable #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to work around issues in compiler which have now been addressed
oleksandr-pavlyk
changed the title
|
This PR activates a number of tests previously excluded to work around issues in the compiler toolchain. |
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/840/index.html |
Straightforward attempt to transition from using deprecated sycl::program to kernel_bundle caused crashes. SYCL spec stipulates that cgh.parallel_for(.., kernel) is intended for interoperability kernels only, and dpcpp_kernels.hpp was creating non-interoperability kernel objects. The intent of dpcpp_kernels was improve test coverage of syclinterface, but this was addressed by also collecting library coverage info when running pytests
oleksandr-pavlyk
force-pushed
the
get-rid-of-dpctl-coverage-clutch
branch
from
e4392d6 to
414b209
Compare
oleksandr-pavlyk
force-pushed
the
get-rid-of-dpctl-coverage-clutch
branch
from
414b209 to
571bcaf
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled code previously excluded due to use of
DPCTL_COVERAGEvariable to work around issues in compiler which have now been addressed.